|
|
|
|
using Alphaleonis.Win32.Filesystem;
|
|
|
|
|
using System.Collections.Generic;
|
|
|
|
|
using System.Security.AccessControl;
|
|
|
|
|
|
|
|
|
|
namespace Security2
|
|
|
|
|
{
|
|
|
|
|
public partial class FileSystemAccessRule2
|
|
|
|
|
{
|
|
|
|
|
public static FileSystemAccessRule2 AddFileSystemAccessRule(FileSystemSecurity2 sd, IdentityReference2 account, FileSystemRights2 rights, AccessControlType type, InheritanceFlags inheritanceFlags, PropagationFlags propagationFlags)
|
|
|
|
|
{
|
|
|
|
|
if (type == AccessControlType.Allow)
|
|
|
|
|
rights = rights | FileSystemRights2.Synchronize;
|
|
|
|
|
|
|
|
|
|
FileSystemAccessRule ace = null;
|
|
|
|
|
|
|
|
|
|
if (sd.IsFile)
|
|
|
|
|
{
|
|
|
|
|
ace = (FileSystemAccessRule)sd.SecurityDescriptor.AccessRuleFactory(account, (int)rights, false, InheritanceFlags.None, PropagationFlags.None, type);
|
|
|
|
|
((FileSecurity)sd.SecurityDescriptor).AddAccessRule(ace);
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
ace = (FileSystemAccessRule)sd.SecurityDescriptor.AccessRuleFactory(account, (int)rights, false, inheritanceFlags, propagationFlags, type);
|
|
|
|
|
((DirectorySecurity)sd.SecurityDescriptor).AddAccessRule(ace);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return ace;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static FileSystemAccessRule2 AddFileSystemAccessRule(FileSystemInfo item, IdentityReference2 account, FileSystemRights2 rights, AccessControlType type, InheritanceFlags inheritanceFlags, PropagationFlags propagationFlags)
|
|
|
|
|
{
|
|
|
|
|
if (type == AccessControlType.Allow)
|
|
|
|
|
rights = rights | FileSystemRights2.Synchronize;
|
|
|
|
|
|
fix: write only the sections of the security descriptor that a cmdlet changes
The access and audit cmdlets wrote the owner of an item back with the
entries they changed. For a DACL without the auto-inherit flag, Windows
returns the owner and the group even when only the DACL is read, and the
cmdlets wrote every section that the descriptor held. Without the Restore
privilege, or on a file server that refuses the owner, the write failed
with error 1307 (#34).
- Add-NTFSAccess, Clear-NTFSAccess, Add-NTFSAudit, and Clear-NTFSAudit
read only the DACL or the SACL. FileSystemSecurity2.Write(),
Remove-NTFSAccess, and Remove-NTFSAudit write only the sections they
read, which also fixes the access inheritance cmdlets.
- Read together with the SACL, the inherited entries of such a DACL lose
their inherited flag when the parent folder has no SACL, and the
cmdlets stored them as explicit copies. Get-NTFSSecurityDescriptor now
reads the DACL in a separate call.
- Set-NTFSSecurityDescriptor writes only the sections that changed since
they were read; an unchanged descriptor writes nothing (maintainer
decision of 2026-10-06).
- Clear-NTFSAudit writes nothing for an item without a SACL, and reports
an error without the Security privilege (maintainer decision).
The regression tests failed before and pass after the fix in Windows
PowerShell 5.1 and PowerShell 7, elevated and as a basic user.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: AI Assistant <ai@example.com>
4 weeks ago
|
|
|
// Only the DACL, so that the owner isn't written back (#34) and the inherited entries keep their flag
|
|
|
|
|
var sd = new FileSystemSecurity2(item, AccessControlSections.Access);
|
|
|
|
|
|
|
|
|
|
var ace = AddFileSystemAccessRule(sd, account, rights, type, inheritanceFlags, propagationFlags);
|
|
|
|
|
|
|
|
|
|
sd.Write();
|
|
|
|
|
|
|
|
|
|
return ace;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static IEnumerable<FileSystemAccessRule2> AddFileSystemAccessRule(FileSystemInfo item, List<IdentityReference2> accounts, FileSystemRights2 rights, AccessControlType type, InheritanceFlags inheritanceFlags, PropagationFlags propagationFlags)
|
|
|
|
|
{
|
|
|
|
|
var aces = new List<FileSystemAccessRule2>();
|
|
|
|
|
|
|
|
|
|
foreach (var account in accounts)
|
|
|
|
|
{
|
|
|
|
|
aces.Add(AddFileSystemAccessRule(item, account, rights, type, inheritanceFlags, propagationFlags));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return aces;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static IEnumerable<FileSystemAccessRule2> AddFileSystemAccessRule(FileSystemSecurity2 sd, List<IdentityReference2> accounts, FileSystemRights2 rights, AccessControlType type, InheritanceFlags inheritanceFlags, PropagationFlags propagationFlags)
|
|
|
|
|
{
|
|
|
|
|
var aces = new List<FileSystemAccessRule2>();
|
|
|
|
|
|
|
|
|
|
foreach (var account in accounts)
|
|
|
|
|
{
|
|
|
|
|
aces.Add(AddFileSystemAccessRule(sd, account, rights, type, inheritanceFlags, propagationFlags));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return aces;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static FileSystemAccessRule2 AddFileSystemAccessRule(string path, IdentityReference2 account, FileSystemRights2 rights, AccessControlType type, InheritanceFlags inheritanceFlags, PropagationFlags propagationFlags)
|
|
|
|
|
{
|
|
|
|
|
if (type == AccessControlType.Allow)
|
|
|
|
|
rights = rights | FileSystemRights2.Synchronize;
|
|
|
|
|
|
|
|
|
|
FileSystemAccessRule ace = null;
|
|
|
|
|
|
|
|
|
|
if (File.Exists(path))
|
|
|
|
|
{
|
|
|
|
|
var item = new FileInfo(path);
|
|
|
|
|
ace = AddFileSystemAccessRule(item, account, rights, type, inheritanceFlags, propagationFlags);
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
var item = new DirectoryInfo(path);
|
|
|
|
|
ace = AddFileSystemAccessRule(item, account, rights, type, inheritanceFlags, propagationFlags);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return ace;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static IEnumerable<FileSystemAccessRule2> AddFileSystemAccessRule(string path, List<IdentityReference2> accounts, FileSystemRights2 rights, AccessControlType type, InheritanceFlags inheritanceFlags, PropagationFlags propagationFlags)
|
|
|
|
|
{
|
|
|
|
|
if (type == AccessControlType.Allow)
|
|
|
|
|
rights = rights | FileSystemRights2.Synchronize;
|
|
|
|
|
|
|
|
|
|
if (File.Exists(path))
|
|
|
|
|
{
|
|
|
|
|
var item = new FileInfo(path);
|
|
|
|
|
foreach (var account in accounts)
|
|
|
|
|
{
|
|
|
|
|
yield return AddFileSystemAccessRule(item, account, rights, type, inheritanceFlags, propagationFlags);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
var item = new DirectoryInfo(path);
|
|
|
|
|
foreach (var account in accounts)
|
|
|
|
|
{
|
|
|
|
|
yield return AddFileSystemAccessRule(item, account, rights, type, inheritanceFlags, propagationFlags);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static void AddFileSystemAccessRule(FileSystemAccessRule2 rule)
|
|
|
|
|
{
|
|
|
|
|
AddFileSystemAccessRule(rule.fullName,
|
|
|
|
|
rule.Account,
|
|
|
|
|
rule.AccessRights,
|
|
|
|
|
rule.AccessControlType,
|
|
|
|
|
rule.InheritanceFlags,
|
|
|
|
|
rule.PropagationFlags);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|