test: describe the new tests by behavior, not by review finding
Remove the labels of review findings and the references to probe scripts
and reports that are not in the repository from the comments of the tests
that rc9 adds, and say what each test pins in words that stand alone. Only
comments and the name of one Context in each of two files change; no
assertion does.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: AI Assistant <ai@example.com>
@ -1789,10 +1786,10 @@ Describe 'Invalid and valid values of AccessType, InheritanceFlags, PropagationF
}
}
}
}
# R1-1: rc8 created the entry for every shape below; the object-typed parameters make a $null, an empty
# A typed parameter skips a $null, an empty string, or DBNull value of a property, and the entry was created for
# string, or DBNull value of a property of the other group count as present too, so PowerShell cannot resolve
# every shape below; the object-typed parameters count such a value of a property of the other group as present
# the parameter set and nothing is changed.
# too, so PowerShell cannot resolve the parameter set and nothing is changed.
Context'A blank value of the other groups property'{
Context'A blank value of a property of the other group'{
It'Should reject <Cmdlet> (<TargetKind>) for <Direction> (<Shape>) with the error the binder gives, change nothing, and still process the next object'-ForEach$accessAmbiguousOtherGroupCases{
It'Should reject <Cmdlet> (<TargetKind>) for <Direction> (<Shape>) with the error the binder gives, change nothing, and still process the next object'-ForEach$accessAmbiguousOtherGroupCases{
@ -1826,9 +1823,9 @@ Describe 'Invalid and valid values of AccessType, InheritanceFlags, PropagationF
}
}
}
}
# R1-3: with the object type, a script block is a plain value (rc8's delay-bind evaluation, once per piped
# With the object type, a script block is a plain value (a typed parameter evaluates it once per piped object),
# object, no longer applies), so ValidateNamedValue in BeginProcessing rejects it the same as any other bad
# so ValidateNamedValue in BeginProcessing rejects it the same as any other bad value, before any piped object
# value, before any piped object is processed.
# is processed.
Context'A named script block is a terminating error'{
Context'A named script block is a terminating error'{
It'Should throw a terminating InvalidParameterValue error for a named script block value of <Cmdlet> -<Parameter>, and change nothing'-ForEach$accessScriptBlockCases{
It'Should throw a terminating InvalidParameterValue error for a named script block value of <Cmdlet> -<Parameter>, and change nothing'-ForEach$accessScriptBlockCases{
@ -1445,13 +1443,13 @@ Describe 'Invalid and valid values of AuditFlags, InheritanceFlags, PropagationF
}
}
}
}
# R1-1: rc8 created the entry for every shape below; the object-typed parameters make a $null, an empty
# A typed parameter skips a $null, an empty string, or DBNull value of a property, and the entry was created for
# string, or DBNull value of a property of the other group count as present too, so PowerShell cannot resolve
# every shape below; the object-typed parameters count such a value of a property of the other group as present
# the parameter set and nothing is changed. The conversion/parameter-set failure happens before the cmdlet
# too, so PowerShell cannot resolve the parameter set and nothing is changed. The conversion/parameter-set
# ever touches the SACL, so the core assertion (the error id, and that the bad object's audit entries are
# failure happens before the cmdlet ever touches the SACL, so the core assertion (the error id, and that the bad
# unchanged) runs in every configuration; only the "good next object succeeded" part needs the Security
# object's audit entries are unchanged) runs in every configuration; only the "good next object succeeded" part
# privilege, the same way the rest of this file does.
# needs the Security privilege, the same way the rest of this file does.
Context'A blank value of the other groups property'{
Context'A blank value of a property of the other group'{
It'Should reject <Cmdlet> (<TargetKind>) for <Direction> (<Shape>) with the error the binder gives, change nothing, and still process the next object'-ForEach$auditAmbiguousOtherGroupCases{
It'Should reject <Cmdlet> (<TargetKind>) for <Direction> (<Shape>) with the error the binder gives, change nothing, and still process the next object'-ForEach$auditAmbiguousOtherGroupCases{
@ -1492,11 +1490,10 @@ Describe 'Invalid and valid values of AuditFlags, InheritanceFlags, PropagationF
}
}
}
}
# R1-3: with the object type, a script block is a plain value (rc8's delay-bind evaluation, once per piped
# With the object type, a script block is a plain value (a typed parameter evaluates it once per piped object),
# object, no longer applies), so ValidateNamedValue in BeginProcessing rejects it the same as any other bad
# so ValidateNamedValue in BeginProcessing rejects it the same as any other bad value, before any piped object
# value, before any piped object is processed and before the cmdlet ever touches the SACL. The terminating
# is processed and before the cmdlet ever touches the SACL. The terminating error itself needs no Security
# error itself needs no Security privilege; reading the SACL back to confirm nothing changed does, the same
# privilege; reading the SACL back to confirm nothing changed does, the same way the rest of this file does.
# way the rest of this file does.
Context'A named script block is a terminating error'{
Context'A named script block is a terminating error'{
It'Should throw a terminating InvalidParameterValue error for a named script block value of <Cmdlet> -<Parameter>, and change nothing'-ForEach$auditScriptBlockCases{
It'Should throw a terminating InvalidParameterValue error for a named script block value of <Cmdlet> -<Parameter>, and change nothing'-ForEach$auditScriptBlockCases{
Raimund Andree
1 week ago