fix(access): end a collection that holds itself and name the typo in the message of a list
The check that rejects a list for -AccessType and -AppliesTo opened every level
of a collection of one element, so that a collection that holds itself never
returned. It opens at most 32 levels now and counts a deeper nesting as a list,
and it stops reading a collection after the second element, so that a long or
endless sequence is not read to its end.
The message names what the caller wrote: the one element of a collection of one
element (also when that element is a collection itself), the first ten elements
of a longer collection followed by "...", and otherwise the text of the value.
Before, a collection of one misspelled name was named by its type.
Tests, written first: 28 rows failed on the previous build in all four
configurations and none fails now. They cover an array of one misspelled name,
a collection nested 40 levels deep for both parameters of both cmdlets, and an
array that holds an array of one name, which stays valid. The assertion of the
value text expects "The value '<text>'", because the old pattern could also
match the name of a type. The comments say that PowerShell combines the numbers
of a list bit by bit, which is what it does, and not that it adds them.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: AI Assistant <ai@example.com>
# AccessType and AppliesTo name one value each, not a combination: PowerShell would add the numbers of a list, so that
# one of the values wins silently or, for AppliesTo, a scope that the caller did not name is chosen. Every kind of
# collection counts, also a collection of one element that holds a list.
# AccessType and AppliesTo name one value each, not a combination: PowerShell combines the numbers of a list bit by
# bit, so that one of the values wins silently or, for AppliesTo, a scope that the caller did not name is chosen.
# Every kind of collection counts, also a collection of one element that holds a list.
$accessAppliesToListShapes=@(
@{Shape='a comma list of two names';Value='ThisFolderAndSubfolders,ThisFolderAndFiles';ValueText='ThisFolderAndSubfolders,ThisFolderAndFiles'}
@{Shape='an array of two names';Value=@('ThisFolderAndSubfolders','ThisFolderAndFiles');ValueText='ThisFolderAndSubfolders, ThisFolderAndFiles'}
@{Shape='an array of one comma list';Value=@('ThisFolderAndSubfolders,ThisFolderAndFiles');ValueText='ThisFolderAndSubfolders,ThisFolderAndFiles'}
@{Shape='a hash set of two names';Value=[System.Collections.Generic.HashSet[string]]::new([string[]]@('ThisFolderAndSubfolders','ThisFolderAndFiles'));ValueText=$null}
@{Shape='the keys of a hashtable';Value=(@{ThisFolderAndSubfolders=1;ThisFolderAndFiles=2}).Keys;ValueText=$null}
@{Shape='an array of one misspelled name';Value=@('Failurre');ValueText='Failurre'}
)
# The cross product of the two cmdlets that share these parameters and every bad shape: 2 * (5 + 3 * 5 + 5) = 50 rows.
# AppliesTo names one value, not a combination: PowerShell would add the numbers of a list, so that one of the
# values wins silently or a scope that the caller did not name is chosen. AuditFlags and the two flags parameters
# take a list. Every kind of collection counts, also a collection of one element that holds a list.
# The cross product of the two cmdlets that share these parameters and every bad shape: 2 * (6 + 3 * 6 + 6) = 60 rows.
# AppliesTo names one value, not a combination: PowerShell combines the numbers of a list bit by bit, so that one
# of the values wins silently or a scope that the caller did not name is chosen. AuditFlags and the two flags
# parameters take a list. Every kind of collection counts, also a collection of one element that holds a list.
$auditAppliesToListShapes=@(
@{Shape='a comma list of two names';Value='ThisFolderAndSubfolders,ThisFolderAndFiles';ValueText='ThisFolderAndSubfolders,ThisFolderAndFiles'}
@{Shape='an array of two names';Value=@('ThisFolderAndSubfolders','ThisFolderAndFiles');ValueText='ThisFolderAndSubfolders, ThisFolderAndFiles'}
@{Shape='an array of one comma list';Value=@('ThisFolderAndSubfolders,ThisFolderAndFiles');ValueText='ThisFolderAndSubfolders,ThisFolderAndFiles'}
@{Shape='a hash set of two names';Value=[System.Collections.Generic.HashSet[string]]::new([string[]]@('ThisFolderAndSubfolders','ThisFolderAndFiles'));ValueText=$null}
@{Shape='the keys of a hashtable';Value=(@{ThisFolderAndSubfolders=1;ThisFolderAndFiles=2}).Keys;ValueText=$null}
Raimund Andree
1 week ago