fix(access): reject a list of any kind of collection for -AccessType and -AppliesTo
The rejection of a list for the enumerations that are not flags
enumerations looked only at a string with a comma and at an IList of more
than one element. A collection that is not an IList (a HashSet, a Queue, the
keys of a hashtable, a LINQ sequence), a collection of one element that
holds a comma list (@('Allow,Deny'), such as a JSON array of one string), and
a collection that holds a collection of several elements still reached
LanguagePrimitives.ConvertTo, which added up the numbers: -AppliesTo
$scopes.Keys created a ThisFolderAndFiles entry that nobody named.
ParameterConversion takes the one value out of the argument now: a wrapped
PSObject counts as what it wraps, a collection of one element converts as
its element (also when that element is a collection of one element), and a
collection of several elements or an element with a comma is the list that is
rejected. A dictionary, an empty collection, and a collection that cannot be
enumerated keep going to the conversion, which reports them as before. A
blank value inside a collection of one element is reported as blank.
The tests add the shapes to the bad-value tables of the four cmdlets (32
rows, red before the change and green after it in four configurations) and
pin that a list of one name and a hash set of one name stay valid. The
valid-value matrices of rc8 and this build still differ in the nine list rows
only, and a probe of 50 shapes shows every collection of several values
rejected and every single value accepted, in both editions.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: AI Assistant <ai@example.com>
@{Shape='a comma list of two names';Value='Allow,Deny';ValueText='Allow,Deny'}
@{Shape='an array of two names';Value=@('Allow','Deny');ValueText='Allow, Deny'}
@{Shape='an array of one comma list';Value=@('Allow,Deny');ValueText='Allow,Deny'}
@{Shape='an array that holds an array of two names';Value=,@('Allow','Deny');ValueText='Allow, Deny'}
@{Shape='a hash set of two names';Value=[System.Collections.Generic.HashSet[string]]::new([string[]]@('Allow','Deny'));ValueText=$null}
@{Shape='the keys of a hashtable';Value=(@{Allow=1;Deny=2}).Keys;ValueText=$null}
)
# AccessType and AppliesTo name one value each, not a combination: PowerShell would add the numbers of a list, and
# an entry for a scope that the caller did not name would follow.
# AccessType and AppliesTo name one value each, not a combination: PowerShell would add the numbers of a list, so that
# one of the values wins silently or, for AppliesTo, a scope that the caller did not name is chosen. Every kind of
# collection counts, also a collection of one element that holds a list.
$accessAppliesToListShapes=@(
@{Shape='a comma list of two names';Value='ThisFolderAndSubfolders,ThisFolderAndFiles';ValueText='ThisFolderAndSubfolders,ThisFolderAndFiles'}
@{Shape='an array of two names';Value=@('ThisFolderAndSubfolders','ThisFolderAndFiles');ValueText='ThisFolderAndSubfolders, ThisFolderAndFiles'}
@{Shape='an array of one comma list';Value=@('ThisFolderAndSubfolders,ThisFolderAndFiles');ValueText='ThisFolderAndSubfolders,ThisFolderAndFiles'}
@{Shape='a hash set of two names';Value=[System.Collections.Generic.HashSet[string]]::new([string[]]@('ThisFolderAndSubfolders','ThisFolderAndFiles'));ValueText=$null}
@{Shape='the keys of a hashtable';Value=(@{ThisFolderAndSubfolders=1;ThisFolderAndFiles=2}).Keys;ValueText=$null}
)
# The cross product of the two cmdlets that share these parameters and every bad shape: 2 * (7 + 3 * 5 + 2) = 48 rows.
# The cross product of the two cmdlets that share these parameters and every bad shape: 2 * (11 + 3 * 5 + 5) = 62 rows.
# The cross product of the two cmdlets that share these parameters and every bad shape: 2 * (5 + 3 * 5 + 2) = 42 rows.
# AppliesTo names one value, not a combination: PowerShell would add the numbers of a list, and an entry for a
# scope that the caller did not name would follow. AuditFlags and the two flags parameters take a list.
# The cross product of the two cmdlets that share these parameters and every bad shape: 2 * (5 + 3 * 5 + 5) = 50 rows.
# AppliesTo names one value, not a combination: PowerShell would add the numbers of a list, so that one of the
# values wins silently or a scope that the caller did not name is chosen. AuditFlags and the two flags parameters
# take a list. Every kind of collection counts, also a collection of one element that holds a list.
$auditAppliesToListShapes=@(
@{Shape='a comma list of two names';Value='ThisFolderAndSubfolders,ThisFolderAndFiles';ValueText='ThisFolderAndSubfolders,ThisFolderAndFiles'}
@{Shape='an array of two names';Value=@('ThisFolderAndSubfolders','ThisFolderAndFiles');ValueText='ThisFolderAndSubfolders, ThisFolderAndFiles'}
@{Shape='an array of one comma list';Value=@('ThisFolderAndSubfolders,ThisFolderAndFiles');ValueText='ThisFolderAndSubfolders,ThisFolderAndFiles'}
@{Shape='a hash set of two names';Value=[System.Collections.Generic.HashSet[string]]::new([string[]]@('ThisFolderAndSubfolders','ThisFolderAndFiles'));ValueText=$null}
@{Shape='the keys of a hashtable';Value=(@{ThisFolderAndSubfolders=1;ThisFolderAndFiles=2}).Keys;ValueText=$null}
Raimund Andree
2 weeks ago